linux-kernel - Re: [PATCH v4 4/4] KVM: s390: Minor refactor of base/ext facility lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f41ab6b0-d2e4-481b-b972-99dd9048eafa@linux.ibm.com>
Date: Wed, 20 Dec 2023 11:48:31 +0100
From: Janosch Frank <frankja@...ux.ibm.com>
To: Nina Schoetterl-Glausch <nsg@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Vasily Gorbik
 <gor@...ux.ibm.com>, Heiko Carstens <hca@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>
Cc: linux-s390@...r.kernel.org, David Hildenbrand <david@...hat.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH v4 4/4] KVM: s390: Minor refactor of base/ext facility
 lists

On 12/19/23 15:08, Nina Schoetterl-Glausch wrote:
> Directly use the size of the arrays instead of going through the
> indirection of kvm_s390_fac_size().
> Don't use magic number for the number of entries in the non hypervisor
> managed facility bit mask list.
> Make the constraint of that number on kvm_s390_fac_base obvious.
> Get rid of implicit double anding of stfle_fac_list.
> 
> Reviewed-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>
> Signed-off-by: Nina Schoetterl-Glausch <nsg@...ux.ibm.com>

@Nina: I'm currently still recovering from a cold and hence I'm not 
fully able to grasp this patch.

May I drop it and we re-visit it next year for 6.9?