linux-kernel - Re: [PATCH v2 20/22] device property: Modify fwnode irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANg-bXCshpg5=rRiaxbjdEeD3VNsdV-cKxu-nCqT7K_f8wJodA@mail.gmail.com>
Date: Thu, 21 Dec 2023 16:52:15 -0700
From: Mark Hasemeyer <markhas@...omium.org>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: LKML <linux-kernel@...r.kernel.org>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Tzung-Bi Shih <tzungbi@...nel.org>, 
	Raul Rangel <rrangel@...omium.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, 
	Andy Shevchenko <andriy.shevchenko@...el.com>, Rob Herring <robh@...nel.org>, 
	Sudeep Holla <sudeep.holla@....com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Daniel Scally <djrscally@...il.com>, Frank Rowand <frowand.list@...il.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Len Brown <lenb@...nel.org>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org, 
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2 20/22] device property: Modify fwnode irq_get() to use resource

> Both acpi_irq_get() and of_irq_to_resourece() use EXPORT_SYMBOL_GPL()
> instead. I don't see why fwnode_irq_get_resource() shouldn't do the same.
>
> With this changed,
>
> Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
>
> In fact this should have always been the case for fwnode_irq_get(). I
> wouldn't mind changing that, too, in a separate patch.

Sure. It looks like fwnode_iomap(), fwnode_irq_get(),
fwnode_irq_get_byname(), and fwnode_graph_parse_endpoint() could all
be updated. I'll add another patch with these changes unless there's a
reason some of those functions shouldn't be GPL'd?