| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <250fead9-868b-4063-a054-4cb966dc4ba3@linaro.org>
Date: Thu, 21 Dec 2023 10:28:52 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Moudy Ho <moudy.ho@...iatek.com>, Chun-Kuang Hu
<chunkuang.hu@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Hans Verkuil <hverkuil-cisco@...all.nl>
Cc: dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v10 02/16] dt-bindings: media: mediatek: mdp3: merge the
indentical RDMA under display
On 20/12/2023 11:08, Moudy Ho wrote:
> To simplify maintenance and avoid branches, the identical component
> should be merged and placed in the path belonging to the MDP
> (from display/* to media/*).
Combining bindings into one bigger meta-binding makes it usually more
difficult to maintain and review.
>
> In addition, currently only MDP utilizes RDMA through CMDQ, and the
> necessary properties for "mediatek,gce-events", and "mboxes" have been
> set up for this purpose.
> Within DISP, it directly receives component interrupt signals.
>
> Signed-off-by: Moudy Ho <moudy.ho@...iatek.com>
> ---
> .../display/mediatek/mediatek,mdp-rdma.yaml | 92 -------------------
> .../bindings/media/mediatek,mdp3-rdma.yaml | 43 ++++++++-
> 2 files changed, 40 insertions(+), 95 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
> deleted file mode 100644
> index 7570a0684967..000000000000
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
> +++ /dev/null
> @@ -1,92 +0,0 @@
> -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> -%YAML 1.2
> ----
> -$id: http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: MediaTek MDP RDMA
> -
> -maintainers:
> - - Chun-Kuang Hu <chunkuang.hu@...nel.org>
> - - Philipp Zabel <p.zabel@...gutronix.de>
> -
> -description:
> - The MediaTek MDP RDMA stands for Read Direct Memory Access.
> - It provides real time data to the back-end panel driver, such as DSI,
> - DPI and DP_INTF.
> - It contains one line buffer to store the sufficient pixel data.
> - RDMA device node must be siblings to the central MMSYS_CONFIG node.
> - For a description of the MMSYS_CONFIG binding, see
> - Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml for details.
> -
> -properties:
> - compatible:
> - oneOf:
> - - const: mediatek,mt8195-vdo1-rdma
> - - items:
> - - const: mediatek,mt8188-vdo1-rdma
> - - const: mediatek,mt8195-vdo1-rdma
> -
> - reg:
> - maxItems: 1
> -
> - interrupts:
> - maxItems: 1
> -
> - power-domains:
> - maxItems: 1
> -
> - clocks:
> - items:
> - - description: RDMA Clock
> -
> - iommus:
> - maxItems: 1
> -
> - mediatek,gce-client-reg:
> - description:
> - The register of display function block to be set by gce. There are 4 arguments,
> - such as gce node, subsys id, offset and register size. The subsys id that is
> - mapping to the register of display function blocks is defined in the gce header
> - include/dt-bindings/gce/<chip>-gce.h of each chips.
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> - items:
> - items:
> - - description: phandle of GCE
> - - description: GCE subsys id
> - - description: register offset
> - - description: register size
> - maxItems: 1
> -
> -required:
> - - compatible
> - - reg
> - - power-domains
> - - clocks
> - - iommus
> - - mediatek,gce-client-reg
> -
> -additionalProperties: false
> -
> -examples:
> - - |
> - #include <dt-bindings/interrupt-controller/arm-gic.h>
> - #include <dt-bindings/clock/mt8195-clk.h>
> - #include <dt-bindings/power/mt8195-power.h>
> - #include <dt-bindings/gce/mt8195-gce.h>
> - #include <dt-bindings/memory/mt8195-memory-port.h>
> -
> - soc {
> - #address-cells = <2>;
> - #size-cells = <2>;
> -
> - rdma@...04000 {
> - compatible = "mediatek,mt8195-vdo1-rdma";
> - reg = <0 0x1c104000 0 0x1000>;
> - interrupts = <GIC_SPI 495 IRQ_TYPE_LEVEL_HIGH 0>;
> - clocks = <&vdosys1 CLK_VDO1_MDP_RDMA0>;
> - power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS1>;
> - iommus = <&iommu_vdo M4U_PORT_L2_MDP_RDMA0>;
> - mediatek,gce-client-reg = <&gce0 SUBSYS_1c10XXXX 0x4000 0x1000>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> index e1ffe7eb2cdf..e9955639ce19 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> @@ -20,8 +20,12 @@ description: |
>
> properties:
> compatible:
> - items:
> + oneOf:
> - const: mediatek,mt8183-mdp3-rdma
> + - const: mediatek,mt8195-vdo1-rdma
> + - items:
> + - const: mediatek,mt8188-vdo1-rdma
> + - const: mediatek,mt8195-vdo1-rdma
>
> reg:
> maxItems: 1
> @@ -60,6 +64,7 @@ properties:
> items:
> - description: RDMA clock
> - description: RSZ clock
> + minItems: 1
>
> iommus:
> maxItems: 1
> @@ -68,6 +73,10 @@ properties:
> items:
> - description: used for 1st data pipe from RDMA
> - description: used for 2nd data pipe from RDMA
> + minItems: 1
> +
> + interrupts:
> + maxItems: 1
Why existing devices now support interrupts?
>
> '#dma-cells':
> const: 1
> @@ -76,13 +85,41 @@ required:
> - compatible
> - reg
> - mediatek,gce-client-reg
> - - mediatek,gce-events
> - power-domains
> - clocks
> - iommus
> - - mboxes
> - '#dma-cells'
I see little value in this commit, considering that next month you will
want to split it because it will grow unmaintainable.
Best regards,
Krzysztof
Powered by blists - more mailing lists