linux-kernel - Re: [PATCH] afs: remove redundant overwriting of ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1660754.1703167849@warthog.procyon.org.uk>
Date: Thu, 21 Dec 2023 14:10:49 +0000
From: David Howells <dhowells@...hat.com>
To: Anastasia Belova <abelova@...ralinux.ru>
Cc: dhowells@...hat.com, Marc Dionne <marc.dionne@...istor.com>,
    linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org,
    lvc-project@...uxtesting.org
Subject: Re: [PATCH] afs: remove redundant overwriting of ret

Anastasia Belova <abelova@...ralinux.ru> wrote:

> @@ -409,7 +409,6 @@ static int afs_update_cell(struct afs_cell *cell)
>  		if (ret == -ENOMEM)
>  			goto out_wake;
>  
> -		ret = -ENOMEM;
>  		vllist = afs_alloc_vlserver_list(0);
>  		if (!vllist)
>  			goto out_wake;

This isn't a sufficient fix.

Yes, you're right, we need to keep ret - but we do need to set -ENOMEM if
!vllist if ret does not hold an error.

David