linux-kernel - Re: [v5,43/44] drm/sun4i: hdmi: Consolidate atomic_check and mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf45f0f7-8772-4f95-94b5-0078ac20b8b7@linux.dev>
Date: Thu, 21 Dec 2023 22:53:26 +0800
From: Sui Jingfeng <sui.jingfeng@...ux.dev>
To: Maxime Ripard <mripard@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, Emma Anholt <emma@...olt.net>,
 Jonathan Corbet <corbet@....net>, Sandy Huang <hjc@...k-chips.com>,
 Heiko Stübner <heiko@...ech.de>,
 Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, Hans Verkuil <hverkuil@...all.nl>,
 linux-rockchip@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [v5,43/44] drm/sun4i: hdmi: Consolidate atomic_check and
 mode_valid

Hi,


On 2023/12/7 23:50, Maxime Ripard wrote:
> atomic_check and mode_valid do not check for the same things which can
> lead to surprising result if the userspace commits a mode that didn't go
> through mode_valid. Let's merge the two implementations into a function
> called by both.
>
> Signed-off-by: Maxime Ripard <mripard@...nel.org>


Acked-by: Sui Jingfeng <sui.jingfeng@...ux.dev>