linux-kernel - Re: [PATCH RFC v3 for-6.8/block 12/17] nilfs2: use bdev api in nilfs_attach_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKFNMo=TuhzyEs_NEOdYgJz+UVizU6Ojx4ZKXowDaux3kKddUQ@mail.gmail.com>
Date: Thu, 21 Dec 2023 23:54:30 +0900
From: Ryusuke Konishi <konishi.ryusuke@...il.com>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: axboe@...nel.dk, roger.pau@...rix.com, colyli@...e.de, 
	kent.overstreet@...il.com, joern@...ybastard.org, miquel.raynal@...tlin.com, 
	richard@....at, vigneshr@...com, sth@...ux.ibm.com, hoeppner@...ux.ibm.com, 
	hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com, 
	jejb@...ux.ibm.com, martin.petersen@...cle.com, clm@...com, 
	josef@...icpanda.com, dsterba@...e.com, viro@...iv.linux.org.uk, 
	brauner@...nel.org, nico@...xnic.net, xiang@...nel.org, chao@...nel.org, 
	tytso@....edu, adilger.kernel@...ger.ca, jack@...e.com, willy@...radead.org, 
	akpm@...ux-foundation.org, hare@...e.de, p.raghav@...sung.com, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, 
	xen-devel@...ts.xenproject.org, linux-bcache@...r.kernel.org, 
	linux-mtd@...ts.infradead.org, linux-s390@...r.kernel.org, 
	linux-scsi@...r.kernel.org, linux-bcachefs@...r.kernel.org, 
	linux-btrfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org, 
	linux-nilfs@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com, 
	yangerkun@...wei.com
Subject: Re: [PATCH RFC v3 for-6.8/block 12/17] nilfs2: use bdev api in nilfs_attach_log_writer()

On Thu, Dec 21, 2023 at 6:00 PM Yu Kuai wrote:
>
> From: Yu Kuai <yukuai3@...wei.com>
>
> Avoid to access bd_inode directly, prepare to remove bd_inode from
> block_device.
>
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>  fs/nilfs2/segment.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
> index 55e31cc903d1..a1130e384937 100644
> --- a/fs/nilfs2/segment.c
> +++ b/fs/nilfs2/segment.c
> @@ -2823,7 +2823,7 @@ int nilfs_attach_log_writer(struct super_block *sb, struct nilfs_root *root)
>         if (!nilfs->ns_writer)
>                 return -ENOMEM;
>
> -       inode_attach_wb(nilfs->ns_bdev->bd_inode, NULL);
> +       bdev_attach_wb(nilfs->ns_bdev);
>
>         err = nilfs_segctor_start_thread(nilfs->ns_writer);
>         if (unlikely(err))
> --
> 2.39.2
>

Acked-by: Ryusuke Konishi <konishi.ryusuke@...il.com>

Thanks,
Ryusuke Konishi