linux-kernel - Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231222105200.e73d58640d8be7da89331deb@kernel.org>
Date: Fri, 22 Dec 2023 10:52:00 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Masami Hiramatsu (Google) <mhiramat@...nel.org>
Cc: Steven Rostedt <rostedt@...dmis.org>, LKML
 <linux-kernel@...r.kernel.org>, Linux Trace Kernel
 <linux-trace-kernel@...r.kernel.org>, Mark Rutland <mark.rutland@....com>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Linus Torvalds
 <torvalds@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>, Linux
 selftests <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v2] tracing/selftests: Add ownership modification tests
 for eventfs

On Fri, 22 Dec 2023 10:48:41 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> On Thu, 21 Dec 2023 20:28:13 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > On Fri, 22 Dec 2023 10:21:48 +0900
> > Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:
> > 
> > > The testcase itself is OK but is there any way to identify the system
> > > supports eventfs or not? I ran this test on v6.5.13 for checking then
> > > it failed. We may need to skip (unsupported) this test for such case.
> > 
> > Hmm, honestly, it should technically work on all past versions.
> > 
> > I'll try it out to see what fails for 6.5.13. Perhaps there was another bug
> > that the stable releases need fixing for?
> 
> I found that the failure was my environmental issue.
> BTW, for busybox environment, 
> 
> +instance="foo-$(mktemp -u XXXXX)"
> 
> This doesn't work. it needs XXXXXX (6 times X). And this is
> somewhat wrong usage of mktemp because it can not check there is
> foo-<random>.
> What about change it as
> 
> instance="$(mktemp -u foo-XXXXXX)"
> 
> ?

And I confirmed that this test passed on v6.5.13 with that change.

Thank you,

> 
> Thanks,
> 
> > 
> > -- Steve
> 
> 
> -- 
> Masami Hiramatsu (Google) <mhiramat@...nel.org>


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>