linux-kernel - Re: [PATCH] checkpatch: ignore deleted lines for comment context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 22 Dec 2023 15:15:52 -0800
From: Joe Perches <joe@...ches.com>
To: Andreas Dilger <adilger@...mcloud.com>, Andy Whitcroft
 <apw@...onical.com>
Cc: linux-kernel@...r.kernel.org, Andreas Dilger <adilger@...ger.ca>
Subject: Re: [PATCH] checkpatch: ignore deleted lines for comment context

On Fri, 2023-12-22 at 16:05 -0700, Andreas Dilger wrote:
> From: Andreas Dilger <adilger@...ger.ca>
> 
> Don't consider lines being removed by a patch as part of a comment.
> Otherwise, false "WARNING: memory barrier without comment" and similar
> issues can be reported when a comment does exist on the previous line.
> 
> For example, a change like below was previously incorrectly flagged:
> 
> 	/* matched by smp_store_release() in some_function() */
>  -	if (smp_load_acquire(&list->tail) == head))
>  +	if (smp_load_acquire(&list->tail) == head) && flags == 0)
> 
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>

OK, but:

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -1972,7 +1972,8 @@ sub ctx_locate_comment {
>  	$current_comment = '';
>  	for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
>  		my $line = $rawlines[$linenr - 1];
> -		#warn "           $line\n";
> +		#warn "LINE($linenr): $line\n";

This is a superfluous change

> +		next if ($line =~ /^-/); # ignore lines removed by patch
>  		if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
>  			$in_comment = 1;
>  		}