linux-kernel - Re: [PATCH] checkpatch: ignore deleted lines for comment context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <A0551254-5464-429A-9D7E-98065BB544D7@dilger.ca>
Date: Fri, 22 Dec 2023 16:22:29 -0700
From: Andreas Dilger <adilger@...ger.ca>
To: Joe Perches <joe@...ches.com>
Cc: Andy Whitcroft <apw@...onical.com>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: ignore deleted lines for comment context

On Dec 22, 2023, at 4:15 PM, Joe Perches <joe@...ches.com> wrote:
> 
> On Fri, 2023-12-22 at 16:05 -0700, Andreas Dilger wrote:
>> From: Andreas Dilger <adilger@...ger.ca>
>> 
>> Don't consider lines being removed by a patch as part of a comment.
>> Otherwise, false "WARNING: memory barrier without comment" and similar
>> issues can be reported when a comment does exist on the previous line.
>> 
>> For example, a change like below was previously incorrectly flagged:
>> 
>> 	/* matched by smp_store_release() in some_function() */
>> -	if (smp_load_acquire(&list->tail) == head))
>> +	if (smp_load_acquire(&list->tail) == head) && flags == 0)
>> 
>> Signed-off-by: Andreas Dilger <adilger@...ger.ca>
> 
> OK, but:
> 
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -1972,7 +1972,8 @@ sub ctx_locate_comment {
>> 	$current_comment = '';
>> 	for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
>> 		my $line = $rawlines[$linenr - 1];
>> -		#warn "           $line\n";
>> +		#warn "LINE($linenr): $line\n";
> 
> This is a superfluous change

Sure, I can resubmit without it if you want.  I found it helpful when
debugging why this code didn't work in the first place...

> 
>> +		next if ($line =~ /^-/); # ignore lines removed by patch
>> 		if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
>> 			$in_comment = 1;
>> 		}
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)