linux-kernel - Re: [PATCH] badblocks: avoid checking invalid range in badblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 23 Dec 2023 18:38:26 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Coly Li <colyli@...e.de>
Cc: nvdimm@...ts.linux.dev, linux-kernel@...r.kernel.org, 
 linux-block@...r.kernel.org, Ira Weiny <ira.weiny@...el.com>, 
 Dan Williams <dan.j.williams@...el.com>, 
 Geliang Tang <geliang.tang@...e.com>, Hannes Reinecke <hare@...e.de>, 
 NeilBrown <neilb@...e.de>, Vishal L Verma <vishal.l.verma@...el.com>, 
 Xiao Ni <xni@...hat.com>
Subject: Re: [PATCH] badblocks: avoid checking invalid range in
 badblocks_check()


On Sun, 24 Dec 2023 08:28:20 +0800, Coly Li wrote:
> If prev_badblocks() returns '-1', it means no valid badblocks record
> before the checking range. It doesn't make sense to check whether
> the input checking range is overlapped with the non-existed invalid
> front range.
> 
> This patch checkes whether 'prev >= 0' is true before calling
> overlap_front(), to void such invalid operations.
> 
> [...]

Applied, thanks!

[1/1] badblocks: avoid checking invalid range in badblocks_check()
      commit: 146e843f6b09271233c021b1677e561b7dc16303

Best regards,
-- 
Jens Axboe