linux-kernel - Re: [PATCH] badblocks: avoid checking invalid range in badblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <98F03B8B-5A3E-463F-AB27-0AE00DC27CB9@suse.de>
Date: Sun, 24 Dec 2023 10:11:03 +0800
From: Coly Li <colyli@...e.de>
To: Jens Axboe <axboe@...nel.dk>,
 Ira Weiny <ira.weiny@...el.com>
Cc: nvdimm@...ts.linux.dev,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Block Devices <linux-block@...r.kernel.org>,
 Dan Williams <dan.j.williams@...el.com>,
 Geliang Tang <geliang.tang@...e.com>,
 Hannes Reinecke <hare@...e.de>,
 NeilBrown <neilb@...e.de>,
 Vishal L Verma <vishal.l.verma@...el.com>,
 Xiao Ni <xni@...hat.com>
Subject: Re: [PATCH] badblocks: avoid checking invalid range in
 badblocks_check()



> 2023年12月24日 09:38，Jens Axboe <axboe@...nel.dk> 写道：
> 
> On 12/23/23 5:32 PM, Coly Li wrote:
>>> 2023?12?24? 08:28?Coly Li <colyli@...e.de> ???
>>> 
>>> If prev_badblocks() returns '-1', it means no valid badblocks record
>>> before the checking range. It doesn't make sense to check whether
>>> the input checking range is overlapped with the non-existed invalid
>>> front range.
>>> 
>>> This patch checkes whether 'prev >= 0' is true before calling
>>> overlap_front(), to void such invalid operations.
>>> 
>>> Fixes: 3ea3354cb9f0 ("badblocks: improve badblocks_check() for multiple ranges handling")
>>> Reported-and-tested-by: Ira Weiny <ira.weiny@...el.com>
>>> Signed-off-by: Coly Li <colyli@...e.de>
>>> Link: https://lore.kernel.org/nvdimm/3035e75a-9be0-4bc3-8d4a-6e52c207f277@leemhuis.info/
>>> Cc: Dan Williams <dan.j.williams@...el.com>
>>> Cc: Geliang Tang <geliang.tang@...e.com>
>>> Cc: Hannes Reinecke <hare@...e.de>
>>> Cc: Jens Axboe <axboe@...nel.dk>
>>> Cc: NeilBrown <neilb@...e.de>
>>> Cc: Vishal L Verma <vishal.l.verma@...el.com>
>>> Cc: Xiao Ni <xni@...hat.com>
>>> ---
>>> block/badblocks.c | 6 ++++--
>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>> 
>> Hi Jens,
>> 
>> Is it possible to take this fix into 6.7 still? Thanks in advance.
> 
> Yep, we're still a few weeks out, so not a problem.

Jes and Ira,

Thank you all for fast response during holidays.

Happy holidays and merry Christmas!

Coly Li