linux-kernel - Re: [PATCH] IB/iser: iscsi_iser.h: fix kernel-doc warning and spellos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e34aa5c-4e50-4492-b3c2-aed9e06e8236@nvidia.com>
Date: Sun, 24 Dec 2023 02:23:31 +0200
From: Max Gurtovoy <mgurtovoy@...dia.com>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
 Jason Gunthorpe <jgg@...dia.com>
Cc: Sagi Grimberg <sagi@...mberg.me>, Leon Romanovsky <leonro@...dia.com>,
 linux-rdma@...r.kernel.org
Subject: Re: [PATCH] IB/iser: iscsi_iser.h: fix kernel-doc warning and spellos



On 23/12/2023 1:46, Randy Dunlap wrote:
> Drop one kernel-doc comment to prevent a warning:
> 
> iscsi_iser.h:313: warning: Excess struct member 'mr' description in 'iser_device'
> 
> and spell 2 words correctly (buffer and deferred).
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Sagi Grimberg <sagi@...mberg.me>
> Cc: Max Gurtovoy <mgurtovoy@...dia.com>
> Cc: Jason Gunthorpe <jgg@...dia.com>
> Cc: Leon Romanovsky <leonro@...dia.com>
> Cc: linux-rdma@...r.kernel.org
> ---
>   drivers/infiniband/ulp/iser/iscsi_iser.h |    5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff -- a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser/iscsi_iser.h
> --- a/drivers/infiniband/ulp/iser/iscsi_iser.h
> +++ b/drivers/infiniband/ulp/iser/iscsi_iser.h
> @@ -182,7 +182,7 @@ enum iser_data_dir {
>    *
>    * @sg:           pointer to the sg list
>    * @size:         num entries of this sg
> - * @data_len:     total beffer byte len
> + * @data_len:     total buffer byte len
>    * @dma_nents:    returned by dma_map_sg
>    */
>   struct iser_data_buf {
> @@ -299,7 +299,6 @@ struct ib_conn;
>    *
>    * @ib_device:     RDMA device
>    * @pd:            Protection Domain for this device
> - * @mr:            Global DMA memory region
>    * @event_handler: IB events handle routine
>    * @ig_list:	   entry in devices list
>    * @refcount:      Reference counter, dominated by open iser connections
> @@ -389,7 +388,7 @@ struct ib_conn {
>    *                    to max number of post recvs
>    * @max_cmds:         maximum cmds allowed for this connection
>    * @name:             connection peer portal
> - * @release_work:     deffered work for release job
> + * @release_work:     deferred work for release job
>    * @state_mutex:      protects iser onnection state
>    * @stop_completion:  conn_stop completion
>    * @ib_completion:    RDMA cleanup completion

Looks good,

Acked-by: Max Gurtovoy <mgurtovoy@...dia.com>