linux-kernel - [PATCH] badblocks: avoid checking invalid range in badblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231224002820.20234-1-colyli@suse.de>
Date: Sun, 24 Dec 2023 08:28:20 +0800
From: Coly Li <colyli@...e.de>
To: axboe@...nel.dk
Cc: nvdimm@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	linux-block@...r.kernel.org,
	Coly Li <colyli@...e.de>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Geliang Tang <geliang.tang@...e.com>,
	Hannes Reinecke <hare@...e.de>,
	NeilBrown <neilb@...e.de>,
	Vishal L Verma <vishal.l.verma@...el.com>,
	Xiao Ni <xni@...hat.com>
Subject: [PATCH] badblocks: avoid checking invalid range in badblocks_check()

If prev_badblocks() returns '-1', it means no valid badblocks record
before the checking range. It doesn't make sense to check whether
the input checking range is overlapped with the non-existed invalid
front range.

This patch checkes whether 'prev >= 0' is true before calling
overlap_front(), to void such invalid operations.

Fixes: 3ea3354cb9f0 ("badblocks: improve badblocks_check() for multiple ranges handling")
Reported-and-tested-by: Ira Weiny <ira.weiny@...el.com>
Signed-off-by: Coly Li <colyli@...e.de>
Link: https://lore.kernel.org/nvdimm/3035e75a-9be0-4bc3-8d4a-6e52c207f277@leemhuis.info/
Cc: Dan Williams <dan.j.williams@...el.com>
Cc: Geliang Tang <geliang.tang@...e.com>
Cc: Hannes Reinecke <hare@...e.de>
Cc: Jens Axboe <axboe@...nel.dk>
Cc: NeilBrown <neilb@...e.de>
Cc: Vishal L Verma <vishal.l.verma@...el.com>
Cc: Xiao Ni <xni@...hat.com>
---
 block/badblocks.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/block/badblocks.c b/block/badblocks.c
index fc92d4e18aa3..db4ec8b9b2a8 100644
--- a/block/badblocks.c
+++ b/block/badblocks.c
@@ -1312,12 +1312,14 @@ static int _badblocks_check(struct badblocks *bb, sector_t s, int sectors,
 	prev = prev_badblocks(bb, &bad, hint);
 
 	/* start after all badblocks */
-	if ((prev + 1) >= bb->count && !overlap_front(bb, prev, &bad)) {
+	if ((prev >= 0) &&
+	    ((prev + 1) >= bb->count) && !overlap_front(bb, prev, &bad)) {
 		len = sectors;
 		goto update_sectors;
 	}
 
-	if (overlap_front(bb, prev, &bad)) {
+	/* Overlapped with front badblocks record */
+	if ((prev >= 0) && overlap_front(bb, prev, &bad)) {
 		if (BB_ACK(p[prev]))
 			acked_badblocks++;
 		else
-- 
2.35.3