linux-kernel - Re: [PATCH v5 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 24 Dec 2023 10:02:28 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Frank Li <Frank.li@....com>
Cc: manivannan.sadhasivam@...aro.org, bhelgaas@...gle.com,
 conor+dt@...nel.org, devicetree@...r.kernel.org, festevam@...il.com,
 helgaas@...nel.org, hongxing.zhu@....com, imx@...ts.linux.dev,
 kernel@...gutronix.de, krzysztof.kozlowski+dt@...aro.org, kw@...ux.com,
 l.stach@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
 linux-imx@....com, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
 lpieralisi@...nel.org, robh@...nel.org, s.hauer@...gutronix.de,
 shawnguo@...nel.org
Subject: Re: [PATCH v5 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as
 required for iMX8MQ

On 24/12/2023 05:29, Frank Li wrote:
> On Sat, Dec 23, 2023 at 07:40:28PM +0100, Krzysztof Kozlowski wrote:
>> On 20/12/2023 22:36, Frank Li wrote:
>>> iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required
>>> proptery for iMX8MQ to indicate pci controller index.
>>
>>
>> Why it has to be required? Everything will work fine if skipped.
>> Otherwise please provide reason why it must be *required*.
> 
> Next patch will use "linux,pci-domain" as PCI slot ID, instead compared
> with hard code register address.
> 
> The below code will be removed.
> 
> -		if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> -			imx6_pcie->controller_id = 1;
> 
> 
> when there are more than 2 controller, this compare logic will become
> complex. 
> 
> So after next patch, "linux,pci-domain" will be required.

Nothing in commit msg explains this. Why you cannot use some
auto-incremented values when this is missing?

Best regards,
Krzysztof