linux-kernel - Re: [PATCH v5 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 24 Dec 2023 10:04:34 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Frank Li <Frank.li@....com>
Cc: manivannan.sadhasivam@...aro.org, bhelgaas@...gle.com,
 conor+dt@...nel.org, devicetree@...r.kernel.org, festevam@...il.com,
 helgaas@...nel.org, hongxing.zhu@....com, imx@...ts.linux.dev,
 kernel@...gutronix.de, krzysztof.kozlowski+dt@...aro.org, kw@...ux.com,
 l.stach@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
 linux-imx@....com, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
 lpieralisi@...nel.org, robh@...nel.org, s.hauer@...gutronix.de,
 shawnguo@...nel.org
Subject: Re: [PATCH v5 09/16] dt-bindings: imx6q-pcie: Clean up irrationality
 clocks check

On 24/12/2023 05:43, Frank Li wrote:
> On Sat, Dec 23, 2023 at 07:42:12PM +0100, Krzysztof Kozlowski wrote:
>> On 20/12/2023 22:36, Frank Li wrote:
>>> There are clocks and clock-names restriction for difference compatible
>>> string. So needn't irrationality check again for clock's miniItems and
>>> maxItems.
>>
>> That's not really true. Other entry does not restrict clocks and leave
>> items quite flexible. These entries should be combined so all
>> constraints are fixed for all variants.
> 
> There are 7 compatible string at pci/fsl,imx6q-pcie.yaml 

Then explain it in the commit msg. The file you are touching has
something entirely else.

And what about -ep binding? Commit msg explains nothing here as well.


Best regards,
Krzysztof