linux-kernel - Re: [PATCH v6 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Dec 2023 20:09:51 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Frank Li <Frank.Li@....com>
Cc: bhelgaas@...gle.com, conor+dt@...nel.org, devicetree@...r.kernel.org,
 festevam@...il.com, helgaas@...nel.org, hongxing.zhu@....com,
 imx@...ts.linux.dev, kernel@...gutronix.de,
 krzysztof.kozlowski+dt@...aro.org, kw@...ux.com, l.stach@...gutronix.de,
 linux-arm-kernel@...ts.infradead.org, linux-imx@....com,
 linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
 lpieralisi@...nel.org, manivannan.sadhasivam@...aro.org, robh@...nel.org,
 s.hauer@...gutronix.de, shawnguo@...nel.org
Subject: Re: [PATCH v6 09/16] dt-bindings: imx6q-pcie: Clean up irrationality
 clocks check

On 25/12/2023 20:05, Krzysztof Kozlowski wrote:
> On 24/12/2023 19:32, Frank Li wrote:
>> There are clocks and clock-names restriction for difference compatible
>> string. So needn't irrationality check again for clock's miniItems and
>> maxItems.
>>
>> In fsl,imx6q-pcie-ep.yaml
> 
> It is enough to say that bindings referencing this file already define
> these constraints for each of the variants, so the if:else: is redundant.
> 
> Two lines instead of ~20.
> 
>> 	...
>>
>> Acked-by: Rob Herring <robh@...nel.org>
> 
> How did you get it? Please point me to the lore link. This patch
> appeared in v5 and there was no response from Rob, AFAIK.

Ah, this patch was added at v4 and Rob acked that one. It's fine then,
but you still could narrow the commit msg, if there is going to be a
resend. Please write informative but concise messages.

Best regards,
Krzysztof