linux-kernel - Re: [PATCH v6 2/2] lib/string: shrink lib/string.i via IWYU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE-cH4rche0dbKWXHQ89YUZzs6Q6XwRPrfdy5+uox9YnQ-5VXA@mail.gmail.com>
Date: Tue, 26 Dec 2023 10:47:08 -0800
From: Tanzir Hasan <tanzirh@...gle.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Kees Cook <keescook@...omium.org>, Nick Desaulniers <nnn@...gle.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-hardening@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, 
	Greg KH <gregkh@...uxfoundation.org>, llvm@...ts.linux.dev
Subject: Re: [PATCH v6 2/2] lib/string: shrink lib/string.i via IWYU

On Tue, Dec 26, 2023 at 10:35 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Tue, Dec 26, 2023 at 8:00 PM Tanzir Hasan <tanzirh@...gle.com> wrote:
> >
> > This diff uses an open source tool include-what-you-use (IWYU) to modify
> > the include list, changing indirect includes to direct includes. IWYU is
> > implemented using the IWYUScripts github repository which is a tool that
> > is currently undergoing development. These changes seek to improve build
> > times.
> >
> > This change to lib/string.c resulted in a preprocessed size of
> > lib/string.i from 26371 lines to 5321 lines (-80%) for the x86
> > defconfig.
>
> Why did you ignore my tag?

I'm sorry. I forgot you had already reviewed this one. In a future
revision I will include this:
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Best,
Tanzir