linux-kernel - Re: [PATCH v6 1/2] kernel.h: removed REPEAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYxWnC5KEIx0XO5q@smile.fi.intel.com>
Date: Wed, 27 Dec 2023 18:53:48 +0200
From: Andy Shevchenko <andy@...nel.org>
To: Tanzir Hasan <tanzirh@...gle.com>
Cc: Kees Cook <keescook@...omium.org>, Nick Desaulniers <nnn@...gle.com>,
	linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg KH <gregkh@...uxfoundation.org>, llvm@...ts.linux.dev,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v6 1/2] kernel.h: removed REPEAT_BYTE from kernel.h

On Tue, Dec 26, 2023 at 06:00:00PM +0000, Tanzir Hasan wrote:
> This patch creates wordpart.h and includes it in asm/word-at-a-time.h
> for all architectures. WORD_AT_A_TIME_CONSTANTS depends on kernel.h
> because of REPEAT_BYTE. Moving this to another header and including it
> where necessary allows us to not include the bloated kernel.h. Making
> this implicit dependency on REPEAT_BYTE explicit allows for later
> improvements in the lib/string.c inclusion list.

LGTM, and I hope this will not trigger CIs and other build checkers.
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

...

> --- a/arch/powerpc/include/asm/word-at-a-time.h
> +++ b/arch/powerpc/include/asm/word-at-a-time.h
> @@ -4,8 +4,8 @@
>  /*
>   * Word-at-a-time interfaces for PowerPC.
>   */

> -

You can preserve this blank line...

> -#include <linux/kernel.h>
> +#include <linux/bitops.h>
> +#include <linux/wordpart.h>

...here.

>  #include <asm/asm-compat.h>
>  #include <asm/extable.h>

-- 
With Best Regards,
Andy Shevchenko