linux-kernel - Re: [PATCH 2/4] dt-bindings: mmc: add Marvell ac5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ff67469-2522-425a-a96a-25460e38beda@linaro.org>
Date: Wed, 27 Dec 2023 13:38:51 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Elad Nachman <enachman@...vell.com>, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, andrew@...n.ch,
 gregory.clement@...tlin.com, sebastian.hesselbarth@...il.com,
 huziji@...vell.com, ulf.hansson@...aro.org, catalin.marinas@....com,
 will@...nel.org, adrian.hunter@...el.com, thunder.leizhen@...wei.com,
 bhe@...hat.com, akpm@...ux-foundation.org, yajun.deng@...ux.dev,
 chris.zjh@...wei.com, linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc: cyuval@...vell.com
Subject: Re: [PATCH 2/4] dt-bindings: mmc: add Marvell ac5

On 27/12/2023 13:32, Elad Nachman wrote:
> From: Elad Nachman <enachman@...vell.com>
> 
> Add dt bindings for Marvell ac5 eMMC controller
> 
> Signed-off-by: Elad Nachman <enachman@...vell.com>
> ---
>  Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> index 3a8e74894ae0..50c6de8bf0bc 100644
> --- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> @@ -34,6 +34,9 @@ properties:
>            - const: marvell,armada-3700-sdhci
>            - const: marvell,sdhci-xenon
>  
> +      - items:
> +          - const: marvell,ac5-sdhci

Please make earlier const as enum and add it there.

> +          - const: marvell,armada-ap806-sdhci

You also missed here blank line, but that won't matter after above change.


Best regards,
Krzysztof