linux-kernel - Re: [PATCH 07/11] firmware: raspberrypi: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf5303ee-6474-4212-b8a9-f1e99ef98ab7@broadcom.com>
Date: Wed, 27 Dec 2023 17:43:08 +0100
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Arnd Bergmann <arnd@...db.de>, Rob Herring <robh@...nel.org>
Cc: kernel@...gutronix.de,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/11] firmware: raspberrypi: Convert to platform remove
 callback returning void



On 12/27/2023 5:26 PM, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)