linux-kernel - Re: [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ZYxhmDlShZG23u-Y@smile.fi.intel.com>
Date: Wed, 27 Dec 2023 19:40:40 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Nikita Shubin <nikita.shubin@...uefel.me>
Cc: Conor Dooley <conor.dooley@...rochip.com>,
	Ulf Hansson <ulf.hansson@...aro.org>, Joel Stanley <joel@....id.au>,
	Walker Chen <walker.chen@...rfivetech.com>,
	Jonathan Neuschäfer <j.neuschaefer@....net>,
	Huisong Li <lihuisong@...wei.com>, Arnd Bergmann <arnd@...db.de>,
	Wei Xu <xuwei5@...ilicon.com>,
	Emil Renner Berthing <kernel@...il.dk>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alexander Sverdlin <alexander.sverdlin@...il.com>,
	Hal Feng <hal.feng@...rfivetech.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx


On Sat, Dec 23, 2023 at 01:06:04PM +0300, Nikita Shubin wrote:
> On Wed, 2023-12-13 at 20:37 +0200, Andy Shevchenko wrote:
> > On Tue, Dec 12, 2023 at 11:20:25AM +0300, Nikita Shubin wrote:

...

> > > +       dev_info(dev, "EP93xx SoC revision %s\n", attrs->revision);
> > 
> > Hmm... Is this message anyhow useful?
> 
> Can we keep it please ? It makes us happy when we see it in logs for
> historical reasons - it's been there since 2.4.

Maybe it's good to add in the comment area / cover letter why this is useful.

-- 
With Best Regards,
Andy Shevchenko