linux-kernel - Re: [PATCH v3 3/5] ASoC: tas2781: Add tas2563 into header file for DSP mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Wed, 27 Dec 2023 19:41:21 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Shenghao Ding <shenghao-ding@...com>
Cc: broonie@...nel.org, conor+dt@...nel.org, krzysztof.kozlowski@...aro.org,
	robh+dt@...nel.org, kevin-lu@...com, baojun.xu@...com,
	devicetree@...r.kernel.org, lgirdwood@...il.com, perex@...ex.cz,
	pierre-louis.bossart@...ux.intel.com, 13916275206@....com,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	liam.r.girdwood@...el.com, soyer@....hu, tiwai@...e.de,
	peeyush@...com, navada@...com
Subject: Re: [PATCH v3 3/5] ASoC: tas2781: Add tas2563 into header file for
 DSP mode


On Mon, Dec 25, 2023 at 01:39:29PM +0800, Shenghao Ding wrote:
> Move tas2563 from tas2562 header file to tas2781 header file, because
> tas2563 only work in bypass-DSP mode with tas2562 driver. In oder to
> enable DSP mode for tas2563, it has been moved to tas2781 driver. As to
> the hardware part, such as register setting and DSP firmware, all these
> are stored in the binary firmware. What tas2781 drivder dooes is to parse
> the firmware and download them to the tas2781 or tas2563, then power on
> tas2781 or tas2563. So, tas2781 driver can be resued as tas2563 driver。
> Only attention will be paid to downloading corresponding firmware.

>  enum audio_device {
>  	TAS2781	= 0,
> +	TAS2563
>  };

Please, make it ordered, it doesn't seem to be an ABI.

enum audio_device {
	TAS2563,
	TAS2781,
};

Yes, and leave comma as the last entry is _not_ a terminator.

-- 
With Best Regards,
Andy Shevchenko