linux-kernel - Re: [PATCH v4 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c0fdb52-6312-4b3a-9ed8-ca8f38d1010d@linaro.org>
Date: Thu, 28 Dec 2023 08:41:20 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: James Tai <james.tai@...ltek.com>, Thomas Gleixner <tglx@...utronix.de>,
 Marc Zyngier <maz@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: interrupt-controller: Add support for
 Realtek DHC SoCs

On 28/12/2023 07:08, James Tai wrote:
> Add the YAML documentation for Realtek DHC (Digital Home Center) SoCs.
> 
> Signed-off-by: James Tai <james.tai@...ltek.com>

Thank you for your patch. There is something to discuss/improve.

> +  interrupts:
> +    minItems: 1
> +    maxItems: 3
> +    description:
> +      Contains the GIC SPI IRQs mapped to the external interrupt lines.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +  - '#address-cells'
> +  - interrupts
> +
> +additionalProperties: false
> +
> +allOf:

If there is going to be new version/resend, allOf: block goes before
additionalProperties:.

> +  - $ref: /schemas/interrupt-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - realtek,rtd1319-intc-iso
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 1

Why the second interrupt is optional? It's a SoC, the pins are not
configurable usually. Same question for other cases.

> +...

Best regards,
Krzysztof