linux-kernel - RE: [PATCH v4 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Dec 2023 15:59:36 +0000
From: James Tai [戴志峰] <james.tai@...ltek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Thomas Gleixner
	<tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>,
        Rob Herring
	<robh+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH v4 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs

Hi Krzysztof,

>> Add the YAML documentation for Realtek DHC (Digital Home Center) SoCs.
>>
>> Signed-off-by: James Tai <james.tai@...ltek.com>
>
>Thank you for your patch. There is something to discuss/improve.
>
>> +  interrupts:
>> +    minItems: 1
>> +    maxItems: 3
>> +    description:
>> +      Contains the GIC SPI IRQs mapped to the external interrupt lines.
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupt-controller
>> +  - '#interrupt-cells'
>> +  - '#address-cells'
>> +  - interrupts
>> +
>> +additionalProperties: false
>> +
>> +allOf:
>
>If there is going to be new version/resend, allOf: block goes before
>additionalProperties:.
>
I will move the 'allOf: block' to go before 'additionalPropertie' in next patches.

>> +  - $ref: /schemas/interrupt-controller.yaml#
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - realtek,rtd1319-intc-iso
>> +    then:
>> +      properties:
>> +        interrupts:
>> +          minItems: 1
>
>Why the second interrupt is optional? It's a SoC, the pins are not configurable
>usually. Same question for other cases.
>
I thought it was defined this way to accommodate different SoCs.
I will remove the 'minItems'. Should the correct version look like the following?

allOf:
  - $ref: /schemas/interrupt-controller.yaml#
  - if:
      properties:
        compatible:
          enum:
            - realtek,rtd1319-intc-iso
    then:
      properties:
        interrupts:
          items:
            - description: isolation irqs
            - description: rtc irq
...
...

Thanks for your feedback.

Regards,
James