linux-kernel - Re: [PATCH] usb: gadget: u_ether: Re-attach netif device to mirror detachment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6019329.lOV4Wx5bFT@radijator>
Date: Thu, 28 Dec 2023 23:36:02 +0100
From: Duje Mihanović <duje.mihanovic@...le.hr>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Hardik Gajjar <hgajjar@...adit-jv.com>,
 Richard Acayan <mailingradian@...il.com>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH] usb: gadget: u_ether: Re-attach netif device to mirror detachment

On Monday, December 18, 2023 17:45:33 CET, Richard Acayan wrote:
> In 6.7-rc1, there was a netif_device_detach call added to the
> gether_disconnect function. This clears the __LINK_STATE_PRESENT bit of
> the netif device and suppresses pings (ICMP messages) and TCP connection
> requests from the connected host. If userspace temporarily disconnects
> the gadget, such as by temporarily removing configuration in the gadget
> configfs interface, network activity should continue to be processed
> when the gadget is re-connected. Mirror the netif_device_detach call
> with a netif_device_attach call in gether_connect to fix re-connecting
> gadgets.

This fixes the NCM gadget on the PXA1908 phone Luca mentioned on v6.7-rc7.

Tested-by: Duje Mihanović <duje.mihanovic@...le.hr>

Regards,
Duje