linux-kernel - Re: [PATCH] usb: gadget: u_ether: Re-attach netif device to mirror detachment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Dec 2023 08:44:18 +0000
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Luca Weiss <luca@...tu.xyz>
Cc: Hardik Gajjar <hgajjar@...adit-jv.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Richard Acayan <mailingradian@...il.com>,
	Thorsten Leemhuis <regressions@...mhuis.info>,
	Caleb Connolly <caleb.connolly@...aro.org>
Subject: Re: [PATCH] usb: gadget: u_ether: Re-attach netif device to mirror
 detachment

On Thu, Dec 28, 2023 at 10:59:59PM +0100, Luca Weiss wrote:
> On Montag, 18. Dezember 2023 17:45:33 CET Richard Acayan wrote:
> > In 6.7-rc1, there was a netif_device_detach call added to the
> > gether_disconnect function. This clears the __LINK_STATE_PRESENT bit of
> > the netif device and suppresses pings (ICMP messages) and TCP connection
> > requests from the connected host. If userspace temporarily disconnects
> > the gadget, such as by temporarily removing configuration in the gadget
> > configfs interface, network activity should continue to be processed
> > when the gadget is re-connected. Mirror the netif_device_detach call
> > with a netif_device_attach call in gether_connect to fix re-connecting
> > gadgets.
> 
> (+Cc Thorsten Leemhuis)
> 
> This appears to fix the regression on a 6.7-rc5-based build for
> qcom-msm8974pro-fairphone-fp2, that the NCM network gadget doesn't work.
> I've also heard reports from qcom-sdm845 and a PXA1908-based phone (if
> I see this correctly) about issues on 6.7.
> 
> In postmarketOS on the device side the usb0 interface doesn't get the IP
> address assigned correctly it seems, but it seems to behave a bit
> inconsistently - but always broken.
> 
> Anyways, with this patch everything looks good again. I hope this makes
> it for 6.7 final still.

It will have to wait until 6.8-rc1, sorry.