linux-kernel - Re: [PATCH] thermal: core: export the governor register related API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023122922-stature-overlying-c63d@gregkh>
Date: Fri, 29 Dec 2023 08:46:19 +0000
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: Di Shen <cindygm567@...il.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Di Shen <di.shen@...soc.com>,
	daniel.lezcano@...aro.org, rui.zhang@...el.com, lukasz.luba@....com,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	xuewen.yan@...soc.com, zhanglyra@...il.com, orsonzhai@...il.com
Subject: Re: [PATCH] thermal: core: export the governor register related API

On Fri, Dec 29, 2023 at 12:30:10PM +0800, Di Shen wrote:
> Hi Rafael,
> 
> On Fri, Dec 29, 2023 at 4:24 AM Rafael J. Wysocki <rafael@...nel.org> wrote:
> >
> > On Thu, Dec 28, 2023 at 11:39 AM Di Shen <di.shen@...soc.com> wrote:
> > >
> > > To enable users to register their own thermal governor,
> >
> > Why would anyone want to do that?
> >
> 
> On Android systems, due to GKI restrictions, vendors cannot modify the
> kernel, and
> vendor-specific changes must be loaded as modules, so export this symbol so that
> vendors can load their own specific governor.

Why not get the needed changes merged upstream properly instead?  That's
why Android does not allow you to change the core kernel, they want you
to work upstream first.

Random symbol exports are not allowed without a user for obvious reasons
(and you don't want us to take these patches either.)

thanks,

greg k-h