linux-kernel - Re: [PATCH] thermal: core: export the governor register related API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHYJL4p9ocr1FsM_Oc-p-H=NzfVuU3=8NYBwSV8oi+_vNuVUPg@mail.gmail.com>
Date: Fri, 29 Dec 2023 12:30:10 +0800
From: Di Shen <cindygm567@...il.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Di Shen <di.shen@...soc.com>, daniel.lezcano@...aro.org, rui.zhang@...el.com, 
	lukasz.luba@....com, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	xuewen.yan@...soc.com, zhanglyra@...il.com, orsonzhai@...il.com, 
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] thermal: core: export the governor register related API

Hi Rafael,

On Fri, Dec 29, 2023 at 4:24 AM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> On Thu, Dec 28, 2023 at 11:39 AM Di Shen <di.shen@...soc.com> wrote:
> >
> > To enable users to register their own thermal governor,
>
> Why would anyone want to do that?
>

On Android systems, due to GKI restrictions, vendors cannot modify the
kernel, and
vendor-specific changes must be loaded as modules, so export this symbol so that
vendors can load their own specific governor.

> > this patch
> > exports thermal_register_governor() and thermal_unregister_governor().
> > This change would not affect the registration of the default governor.
> >
> > Signed-off-by: Di Shen <di.shen@...soc.com>
> > ---
> >  drivers/thermal/thermal_core.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> > index 9c17d35ccbbd..56695988e20f 100644
> > --- a/drivers/thermal/thermal_core.c
> > +++ b/drivers/thermal/thermal_core.c
> > @@ -167,6 +167,7 @@ int thermal_register_governor(struct thermal_governor *governor)
> >
> >         return err;
> >  }
> > +EXPORT_SYMBOL_GPL(thermal_register_governor);
> >
> >  void thermal_unregister_governor(struct thermal_governor *governor)
> >  {
> > @@ -193,6 +194,7 @@ void thermal_unregister_governor(struct thermal_governor *governor)
> >  exit:
> >         mutex_unlock(&thermal_governor_lock);
> >  }
> > +EXPORT_SYMBOL_GPL(thermal_unregister_governor);
> >
> >  int thermal_zone_device_set_policy(struct thermal_zone_device *tz,
> >                                    char *policy)
> > --
> > 2.17.1
> >
>

Best regards,
Di