linux-kernel - Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 28 Dec 2023 15:37:05 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Andi Shyti <andi.shyti@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
 intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 Rodrigo Vivi <rodrigo.vivi@...el.com>
Subject: Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member
 kernel-doc warnings

Hi Andi,


On 12/28/23 08:40, Andi Shyti wrote:
> Hi Randy,
> 
> [...]
> 
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
>> @@ -105,61 +105,67 @@ struct intel_guc {
>>  	 */
> 
> 
> struct { } interrupts is missing here.
> 
>>  	struct {
>>  		/**
>> -		 * @lock: protects everything in submission_state,
>> -		 * ce->guc_id.id, and ce->guc_id.ref when transitioning in and
> 
> [...]
> 
>> +		 * we start bypassing the schedule disable delay
>>  		 */
>>  		unsigned int sched_disable_gucid_threshold;
>>  	} submission_state;
> 
> Here struct { } send_regs is missing

scripts/kernel-doc didn't report any problems with those, but it does
appear (to me) to be a kernel-doc bug.  :(

Thanks.

> But as for this patch:
> 
> Reviewed-by: Andi Shyti <andi.shyti@...ux.intel.com>
> 
> Thanks,
> Andi
> 
>>  	struct {
>>  		/**
>> -		 * @lock: Lock protecting the below fields and the engine stats.
>> +		 * @timestamp.lock: Lock protecting the below fields and
> 
> [...]

-- 
#Randy