linux-kernel - Re: [PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff236270-8c8c-483f-bae2-f90f94b41d4a@infradead.org>
Date: Thu, 28 Dec 2023 15:42:52 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Andi Shyti <andi.shyti@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
 intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 Rodrigo Vivi <rodrigo.vivi@...el.com>
Subject: Re: [PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member
 kernel-doc warnings

Hi Andi,

On 12/28/23 08:25, Andi Shyti wrote:
> Hi Randy,
> 
> ...
> 
>>  /**
>>   * struct intel_gsc - graphics security controller
>>   *
>> - * @gem_obj: scratch memory GSC operations
>> - * @intf : gsc interface
>> + * @intf :	gsc interface
>> + * @intf.adev :	MEI aux. device for this @intf
>> + * @intf.gem_obj : scratch memory GSC operations
>> + * @intf.irq :	IRQ for this device (%-1 for no IRQ)
>> + * @intf.id :	this interface's id number/index
>>   */
> 
> I don't really like the tabs here and the space before the ':',
> which makes it a bit harder to read. Besides it doesn't look
> consistent with the rest of the documentation.
> 
> Otherwise, looks good.

Yes, one existing line had " : " and somehow I managed to use that on
all of the new lines. Not good. I'll redo patch 2/4.

Thanks.

-- 
#Randy