linux-kernel - Re: [PATCH] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0657f8d7-d09f-41be-85a2-f8bbece0368b@ixit.cz>
Date: Sat, 30 Dec 2023 00:16:17 +0100
From: David Heidelberg <david@...t.cz>
To: Luca Weiss <luca@...tu.xyz>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Caleb Connolly <caleb.connolly@...aro.org>,
 Dylan Van Assche <me@...anvanassche.be>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node
 naming

Weird, I'm on next-20231222 so I assume it got missed somehow :(

Thanks!

On 29/12/2023 22:41, Luca Weiss wrote:
> On Freitag, 29. Dezember 2023 21:02:33 CET David Heidelberg wrote:
>> Make it easier to understand what the reg in those nodes is by using the
>> constants provided by qcom,q6dsp-lpass-ports.h.
>>
>> Name nodes according to dt-binding expectations.
>>
>> Fix for
>> ```
>> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: service@4: dais:
>> Unevaluated properties are not allowed ('qi2s@22', 'qi2s@23' were
>> unexpected) ```
>>
>> Fixes: b7b734286856 ("arm64: dts: qcom: sdm845-oneplus-*: add audio
>> devices") Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi index
>> e821103d49c0..46e25c53829a 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -508,13 +508,13 @@ led-1 {
>>   };
>>
>>   &q6afedai {
>> -	qi2s@22 {
>> -		reg = <22>;
>> +	dai@22 {
>> +		reg = <QUATERNARY_MI2S_RX>;
>>   		qcom,sd-lines = <1>;
>>   	};
>>
>> -	qi2s@23 {
>> -		reg = <23>;
>> +	dai@23 {
>> +		reg = <QUATERNARY_MI2S_TX>;
> I did the 'reg' part before, either I missed this file or it was added after I
> made the patch.
> https://lore.kernel.org/linux-arm-msm/20220603094710.64591-1-luca.weiss@fairphone.com/
>
> But looks correct:
>
> Reviewed-by: Luca Weiss <luca@...tu.xyz>
>
>
>>   		qcom,sd-lines = <0>;
>>   	};
>>   };
>
>
>
-- 
David Heidelberg