linux-kernel - Re: [PATCH] sunrpc: Improve exception handling in krb5_etm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f96d8343-e7b3-491d-b191-f2ddb4ba5269@web.de>
Date: Tue, 2 Jan 2024 10:26:12 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Chuck Lever <chuck.lever@...cle.com>, linux-nfs@...r.kernel.org,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Cc: Anna Schumaker <anna@...nel.org>, Ard Biesheuvel <ardb@...nel.org>,
 Dai Ngo <Dai.Ngo@...cle.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, Jakub Kicinski <kuba@...nel.org>,
 Jeff Layton <jlayton@...nel.org>, Neil Brown <neilb@...e.de>,
 Olga Kornievskaia <kolga@...app.com>, Paolo Abeni <pabeni@...hat.com>,
 Simo Sorce <simo@...hat.com>, Tom Talpey <tom@...pey.com>,
 Trond Myklebust <trond.myklebust@...merspace.com>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sunrpc: Improve exception handling in krb5_etm_checksum()

…
> +++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c
…
> @@ -970,8 +969,7 @@ u32 krb5_etm_checksum(struct crypto_sync_skcipher *cipher,
>
>  out_free_ahash:
>  	ahash_request_free(req);
> -out_free_mem:
> -	kfree(iv);
> +out_free_cksumdata:
>  	kfree_sensitive(checksumdata);
>  	return err ? GSS_S_FAILURE : GSS_S_COMPLETE;
>  }
…

How do you think about to use the identifier “out_free_checksumdata”?

Regards,
Markus