linux-kernel - Re: [PATCH 2/2] arm64: dts: mediatek: mt8186: Add jpgenc node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39d7a40b-3618-4746-9229-c9dbe1e19d2e@collabora.com>
Date: Tue, 2 Jan 2024 10:28:25 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Eugen Hristev <eugen.hristev@...labora.com>, bin.liu@...iatek.com,
 matthias.bgg@...il.com, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org,
 Allen-KH Cheng <allen-kh.cheng@...iatek.com>,
 Hsin-Yi Wang <hsinyi@...omium.org>, Max Staudt <mstaudt@...omium.org>,
 Ricardo Ribalda <ribalda@...omium.org>
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt8186: Add jpgenc node

Il 27/12/23 14:08, Eugen Hristev ha scritto:
> From: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
> 
> Add JPEG encoder node.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
> Reviewed-by: Hsin-Yi Wang <hsinyi@...omium.org>
> Reviewed-by: Max Staudt <mstaudt@...omium.org>
> Tested-by: Max Staudt <mstaudt@...omium.org>
> Reviewed-by: Ricardo Ribalda <ribalda@...omium.org>
> [eugen.hristev@...labora.com: minor cleanup]
> Signed-off-by: Eugen Hristev <eugen.hristev@...labora.com>
> ---
>   arch/arm64/boot/dts/mediatek/mt8186.dtsi | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> index e451b6c8cd9e..ef1b269f9184 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> @@ -2054,6 +2054,19 @@ venc: video-encoder@...20000 {
>   			mediatek,scp = <&scp>;
>   		};
>   
> +		jpgenc: jpgenc@...30000 {

Can we please call this jpeg-encoder@...30000 instead?

> +			compatible = "mediatek,mt8186-jpgenc", "mediatek,mtk-jpgenc";
> +			reg = <0 0x17030000 0 0x10000>;
> +			interrupts = <GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH 0>;
> +			clocks = <&vencsys CLK_VENC_CKE2_JPGENC>;
> +			clock-names = "jpgenc";

clock-names ...
iommus ....
power-domains ...

Cheers,
Angelo