linux-kernel - Re: [PATCH v3 18/24] of: irq: add wake capable bit to of_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240102160104.GA2915145-robh@kernel.org>
Date: Tue, 2 Jan 2024 09:01:04 -0700
From: Rob Herring <robh@...nel.org>
To: Mark Hasemeyer <markhas@...omium.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, LKML <linux-kernel@...r.kernel.org>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, Sudeep Holla <sudeep.holla@....com>, Raul Rangel <rrangel@...omium.org>, Tzung-Bi Shih <tzungbi@...nel.org>, Frank Rowand <frowand.list@...il.com>, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 18/24] of: irq: add wake capable bit to
 of_irq_resource()

On Wed, Dec 27, 2023 at 11:21:14AM -0700, Mark Hasemeyer wrote:
> >
> > > +             u32 irq_flags;
> > >               const char *name = NULL;
> >
> > Don't know if OF style requires reversed xmas tree order. If so, this should be
> >
> >                 const char *name = NULL;
> >                 u32 irq_flags;
> >
> 
> I see both methods used. For example, of_irq_init() uses normal xmas
> tree order. I'll leave it unless Rob says otherwise.
> It is Christmas time, so I do want to honor the Christmas trees appropriately!

DT requires sideways Christmas tree because we're special. You'll have 
to add a 3rd variable. ;)

Rob