linux-kernel - Re: [PATCH v3 18/24] of: irq: add wake capable bit to of_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <170421130510.2924738.11783263909956971432.robh@kernel.org>
Date: Tue, 2 Jan 2024 09:01:46 -0700
From: Rob Herring <robh@...nel.org>
To: Mark Hasemeyer <markhas@...omium.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Raul Rangel <rrangel@...omium.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, Sudeep Holla <sudeep.holla@....com>, Frank Rowand <frowand.list@...il.com>, Andy Shevchenko <andriy.shevchenko@...el.com>, devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, LKML <linux-kernel@...r.kernel.org>, Tzung-Bi Shih <tzungbi@...nel.org>
Subject: Re: [PATCH v3 18/24] of: irq: add wake capable bit to
 of_irq_resource()


On Tue, 26 Dec 2023 12:21:22 -0700, Mark Hasemeyer wrote:
> Add wake capability information to the IRQ resource. Wake capability is
> assumed based on conventions provided in the devicetree wakeup-source
> binding documentation. An interrupt is considered wake capable if the
> following are true:
> 1. A wakeup-source property exits in the same device node as the
>    interrupt.
> 2. The IRQ is marked as dedicated by setting its interrupt-name to
>    "wakeup".
> 
> The wakeup-source documentation states that dedicated interrupts can use
> device specific interrupt names and device drivers are still welcome to
> use their own naming schemes. This API is provided as a helper if one is
> willing to conform to the above conventions.
> 
> The ACPI subsystems already provides similar APIs that allow one to
> query the wake capability of an IRQ. This brings closer feature parity
> to the devicetree.
> 
> Signed-off-by: Mark Hasemeyer <markhas@...omium.org>
> ---
> 
> Changes in v3:
> -Use DEFINE_RES_IRQ_NAMED_FLAGS macro
> 
> Changes in v2:
> -Update logic to return true only if wakeup-source property and
>  "wakeup" interrupt-name are defined
> -irq->IRQ, api->API
> 
>  drivers/of/irq.c | 39 +++++++++++++++++++++++++++++++++++----
>  1 file changed, 35 insertions(+), 4 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>