linux-kernel - [PATCH linux-next] drm/panel: samsung: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <061ed94a003362bb7d7e9d3e4d38358c5b91c8a3.1704186827.git.chen.haonan2@zte.com.cn>
Date: Wed,  3 Jan 2024 22:17:38 +0800
From: chenguanxi11234@....com
To: neil.armstrong@...aro.org
Cc: cgel.zte@...il.com,
	yang.guang5@....com.cn,
	quic_jesszhan@...cinc.com,
	sam@...nborg.org,
	maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org,
	tzimmermann@...e.de,
	airlied@...il.com,
	daniel@...ll.ch,
	dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org,
	Chen Haonan <chen.haonan2@....com.cn>
Subject: [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe()

From: Chen Haonan <chen.haonan2@....com.cn>

dev_err_probe() can check if the error code is -EPROBE_DEFER 
and can return the error code, replacing dev_err() with it 
simplifies the code.

Signed-off-by: Chen Haonan <chen.haonan2@....com.cn>
---
 drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
index 79f611963c61..f4103e762b53 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
@@ -194,10 +194,8 @@ static int s6d16d0_probe(struct mipi_dsi_device *dsi)
 	s6->reset_gpio = devm_gpiod_get_optional(dev, "reset",
 						GPIOD_OUT_HIGH);
 	if (IS_ERR(s6->reset_gpio)) {
-		ret = PTR_ERR(s6->reset_gpio);
-		if (ret != -EPROBE_DEFER)
-			dev_err(dev, "failed to request GPIO (%d)\n", ret);
-		return ret;
+		return dev_err_probe(dev, PTR_ERR(s6->reset_gpio),
+							 "failed to request GPIO\n");
 	}
 
 	drm_panel_init(&s6->panel, dev, &s6d16d0_drm_funcs,
-- 
2.25.1