linux-kernel - Re: [PATCH linux-next] drm/panel: samsung: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7354b0a-9199-425a-8146-9de97cbeffea@quicinc.com>
Date: Wed, 3 Jan 2024 09:37:18 -0800
From: Jessica Zhang <quic_jesszhan@...cinc.com>
To: <chenguanxi11234@....com>, <neil.armstrong@...aro.org>
CC: <cgel.zte@...il.com>, <linux-kernel@...r.kernel.org>, <mripard@...nel.org>,
        Chen Haonan <chen.haonan2@....com.cn>, <yang.guang5@....com.cn>,
        <dri-devel@...ts.freedesktop.org>, <tzimmermann@...e.de>,
        <sam@...nborg.org>
Subject: Re: [PATCH linux-next] drm/panel: samsung: Simplify with
 dev_err_probe()



On 1/3/2024 6:17 AM, chenguanxi11234@....com wrote:
> From: Chen Haonan <chen.haonan2@....com.cn>
> 
> dev_err_probe() can check if the error code is -EPROBE_DEFER
> and can return the error code, replacing dev_err() with it
> simplifies the code.
> 
> Signed-off-by: Chen Haonan <chen.haonan2@....com.cn>

Reviewed-by: Jessica Zhang <quic_jesszhan@...cinc.com>

> ---
>   drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> index 79f611963c61..f4103e762b53 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> @@ -194,10 +194,8 @@ static int s6d16d0_probe(struct mipi_dsi_device *dsi)
>   	s6->reset_gpio = devm_gpiod_get_optional(dev, "reset",
>   						GPIOD_OUT_HIGH);
>   	if (IS_ERR(s6->reset_gpio)) {
> -		ret = PTR_ERR(s6->reset_gpio);
> -		if (ret != -EPROBE_DEFER)
> -			dev_err(dev, "failed to request GPIO (%d)\n", ret);
> -		return ret;
> +		return dev_err_probe(dev, PTR_ERR(s6->reset_gpio),
> +							 "failed to request GPIO\n");
>   	}
>   
>   	drm_panel_init(&s6->panel, dev, &s6d16d0_drm_funcs,
> -- 
> 2.25.1
>