[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <789bffea-cc4a-4752-8113-31101df951bf@linaro.org>
Date: Fri, 12 Jan 2024 10:35:25 +0100
From: neil.armstrong@...aro.org
To: chenguanxi11234@....com
Cc: cgel.zte@...il.com, yang.guang5@....com.cn, quic_jesszhan@...cinc.com,
sam@...nborg.org, maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Chen Haonan <chen.haonan2@....com.cn>
Subject: Re: [PATCH linux-next] drm/panel: samsung: Simplify with
dev_err_probe()
On 03/01/2024 15:17, chenguanxi11234@....com wrote:
> From: Chen Haonan <chen.haonan2@....com.cn>
>
> dev_err_probe() can check if the error code is -EPROBE_DEFER
> and can return the error code, replacing dev_err() with it
> simplifies the code.
>
> Signed-off-by: Chen Haonan <chen.haonan2@....com.cn>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> index 79f611963c61..f4103e762b53 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c
> @@ -194,10 +194,8 @@ static int s6d16d0_probe(struct mipi_dsi_device *dsi)
> s6->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> GPIOD_OUT_HIGH);
> if (IS_ERR(s6->reset_gpio)) {
> - ret = PTR_ERR(s6->reset_gpio);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "failed to request GPIO (%d)\n", ret);
> - return ret;
> + return dev_err_probe(dev, PTR_ERR(s6->reset_gpio),
> + "failed to request GPIO\n");
> }
>
> drm_panel_init(&s6->panel, dev, &s6d16d0_drm_funcs,
This patch fails to apply on current drm-misc-next, please refresh.
Neil
Powered by blists - more mailing lists