linux-kernel - Re: [PATCH] drivers/accel/habanalabs: Remove unnecessary braces from if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3732d2b-f6cf-4bf7-af1d-3ee7c4acfd3a@kernel.org>
Date: Wed, 3 Jan 2024 17:42:51 +0200
From: Oded Gabbay <ogabbay@...nel.org>
To: Malkoot Khan <engr.mkhan1990@...il.com>
Cc: fkassabri@...ana.ai, ttayar@...ana.ai, stanislaw.gruszka@...ux.intel.com,
 kelbaz@...ana.ai, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/accel/habanalabs: Remove unnecessary braces from
 if statement

On 28/12/2023 23:08, Malkoot Khan wrote:
> The coding style in the Linux kernel prefers not to use
> braces for single-statement if conditions.
> This patch removes the unnecessary braces from an if statement
> in the file drivers/accel/habanalabs/common/command_submission.c,
> which also resolves a coding style warning.
> 
> Signed-off-by: Malkoot Khan <engr.mkhan1990@...il.com>
> ---
>   drivers/accel/habanalabs/common/command_submission.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/accel/habanalabs/common/command_submission.c b/drivers/accel/habanalabs/common/command_submission.c
> index 3aa6eeef443b..39e23d625a3c 100644
> --- a/drivers/accel/habanalabs/common/command_submission.c
> +++ b/drivers/accel/habanalabs/common/command_submission.c
> @@ -1360,9 +1360,8 @@ static int hl_cs_sanity_checks(struct hl_fpriv *hpriv, union hl_cs_args *args)
>   			return -EINVAL;
>   		}
>   
> -	if (!hl_device_operational(hdev, &status)) {
> +	if (!hl_device_operational(hdev, &status))
>   		return -EBUSY;
> -	}
>   
>   	if ((args->in.cs_flags & HL_CS_FLAGS_STAGED_SUBMISSION) &&
>   			!hdev->supports_staged_submission) {

Thanks for the patch.
Reviewed-by: Oded Gabbay <ogabbay@...nel.org>
Applied to -next.
Oded