linux-kernel - Re: [PATCH v1] perf x86 test: Update hybrid expectations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZZWOdHXJJ_oecWwm@kernel.org>
Date: Wed, 3 Jan 2024 13:42:28 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf x86 test: Update hybrid expectations

Em Tue, Jan 02, 2024 at 01:57:32PM -0800, Ian Rogers escreveu:
> The legacy events cpu-cycles and instructions have sysfs event
> equivalents on x86 (see /sys/devices/cpu_core/events). As sysfs/JSON
> events are now higher in priority than legacy events this causes the
> hybrid test expectations not to be met. To fix this switch to legacy
> events that don't have sysfs versions, namely cpu-cycles becomes
> cycles and instructions becomes branches.
> 
> Fixes: a24d9d9dc096 ("perf parse-events: Make legacy events lower priority than sysfs/JSON")
> Signed-off-by: Ian Rogers <irogers@...gle.com>

With it:

root@...ber:/home/acme# perf test hybrid
 71: Intel PT                                                        :
 71.2: Intel PT hybrid CPU compatibility                             : Ok
 75: x86 hybrid                                                      : Ok
root@...ber:/home/acme#

Applied.

Now to look at this on this hybrid system (14700K):

101: perf all metricgroups test                                      : FAILED!

Testing Mem
event syntax error: '{cpu_core/UNC_ARB_DAT_OCCUPANCY.RD,cmask=1,metric-id=cpu_core!3UNC_ARB_DAT_OCCUPANCY.RD!0cmask!21!3/,UNC_ARB_DAT_OCCUPANCY.RD/metric-id=UNC_ARB_DAT_OCCUPANCY.RD/}:W,du..'
                               \___ Bad event or PMU

Unable to find PMU or event on a PMU of 'cpu_core'

Initial error:
event syntax error: '{cpu_core/UNC_ARB_DAT_OCCUPANCY.RD,cmask=1,metric-id=cpu_core!3UNC_ARB_DAT_OCCUPANCY.RD!0cmask!21!3/,UNC_ARB_DAT_OCCUPANCY.RD/metric-id=UNC_ARB_DAT_OCCUPANCY.RD/}:W,du..'
                               \___ unknown term 'UNC_ARB_DAT_OCCUPANCY.RD' for pmu 'cpu_core'

valid terms: event,pc,edge,offcore_rsp,ldlat,inv,umask,frontend,cmask,config,config1,config2,config3,name,period,percore,metric-id
test child finished with -1
---- end ----
perf all metricgroups test: FAILED!
root@...ber:/home/acme# grep -m1 "model name" /proc/cpuinfo 
model name	: Intel(R) Core(TM) i7-14700K
root@...ber:/home/acme# 


root@...ber:/home/acme# ls -la /sys/devices/uncore_
uncore_arb_0/              uncore_cbox_1/             uncore_cbox_2/             uncore_cbox_5/             uncore_cbox_8/             uncore_imc_0/              uncore_imc_free_running_1/
uncore_arb_1/              uncore_cbox_10/            uncore_cbox_3/             uncore_cbox_6/             uncore_cbox_9/             uncore_imc_1/              
uncore_cbox_0/             uncore_cbox_11/            uncore_cbox_4/             uncore_cbox_7/             uncore_clock/              uncore_imc_free_running_0/ 
root@...ber:/home/acme# ls -la /sys/devices/uncore_


102: perf all metrics test                                           : FAILED!

event syntax error: '{cpu_core/UNC_ARB_DAT_OCCUPANCY.RD,cmask=1,metric-id=cpu..'
                               \___ Bad event or PMU

Unable to find PMU or event on a PMU of 'cpu_core'

Initial error:
event syntax error: '{cpu_core/UNC_ARB_DAT_OCCUPANCY.RD,cmask=1,metric-id=cpu..'
                               \___ unknown term 'UNC_ARB_DAT_OCCUPANCY.RD' for pmu 'cpu_core'

valid terms: event,pc,edge,offcore_rsp,ldlat,inv,umask,frontend,cmask,config,config1,config2,config3,name,period,percore,metric-id


Testing UNCORE_FREQ
Metric 'UNCORE_FREQ' not printed in:
event syntax error: '{tma_info_system_socket_clks/metric-id=tma_info_system_s..'
                      \___ Bad event or PMU

Unable to find PMU or event on a PMU of 'tma_info_system_socket_clks'

Initial error:
event syntax error: '{tma_info_system_socket_clks/metric-id=tma_info_system_s..'
                      \___ Cannot find PMU `tma_info_system_socket_clks'. Missing kernel support?
Testing tma_info_system_socket_clks

- Arnaldo