lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 3 Jan 2024 13:45:38 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf record: Reduce memory for recording lost samples
 event

Em Wed, Dec 06, 2023 at 06:16:27PM -0800, Ian Rogers escreveu:
> Reduce from PERF_SAMPLE_MAX_SIZE to "sizeof(*lost) +
> session->machines.host.id_hdr_size".
> 
> Suggested-by: Namhyung Kim <namhyung@...nel.org>


Thanks, applied to perf-tools-next.

- Arnaldo


> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
> Suggested in:
> https://lore.kernel.org/lkml/CAM9d7cjpYHN_Q63sW70vTCisdW=-SzjsrryUUJjgtZ3+9jdxfA@mail.gmail.com/
> ---
>  tools/perf/builtin-record.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index eb5a398ddb1d..206110fc2799 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -1954,7 +1954,8 @@ static void record__read_lost_samples(struct record *rec)
>  
>  				if (count.lost) {
>  					if (!lost) {
> -						lost = zalloc(PERF_SAMPLE_MAX_SIZE);
> +						lost = zalloc(sizeof(*lost) +
> +							      session->machines.host.id_hdr_size);
>  						if (!lost) {
>  							pr_debug("Memory allocation failed\n");
>  							return;
> @@ -1970,7 +1971,8 @@ static void record__read_lost_samples(struct record *rec)
>  		lost_count = perf_bpf_filter__lost_count(evsel);
>  		if (lost_count) {
>  			if (!lost) {
> -				lost = zalloc(PERF_SAMPLE_MAX_SIZE);
> +				lost = zalloc(sizeof(*lost) +
> +					      session->machines.host.id_hdr_size);
>  				if (!lost) {
>  					pr_debug("Memory allocation failed\n");
>  					return;
> -- 
> 2.43.0.rc2.451.g8631bc7472-goog
> 

-- 

- Arnaldo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ