linux-kernel - Re: [PATCH] x86/syscalls: shrink entry/syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdn8ivC1xKUCgZznQ1pZ1DeRYNoUEYZPB=LiQjdHpciC+g@mail.gmail.com>
Date: Thu, 4 Jan 2024 13:00:42 -0800
From: Nick Desaulniers <ndesaulniers@...gle.com>
To: Tanzir Hasan <tanzirh@...gle.com>
Cc: Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, 
	Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org, 
	Nick Desaulniers <nnn@...gle.com>, Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] x86/syscalls: shrink entry/syscall_64.i via IWYU

On Wed, Jan 3, 2024 at 4:13 PM Tanzir Hasan <tanzirh@...gle.com> wrote:
>
> This diff uses an open source tool include-what-you-use (IWYU) to modify
> the include list, changing indirect includes to direct includes. IWYU is
> implemented using the IWYUScripts github repository which is a tool that
> is currently undergoing development. These changes seek to improve build
> times.
>
> This change to entry/syscall_64.c resulted in a preprocessed size of
> entry/syscall_64.i from 64003 lines to 24509 lines (-62%) for the x86
> defconfig.
>
> Suggested-by: Al Viro <viro@...iv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@...gle.com>
> ---
>  arch/x86/entry/syscall_64.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/entry/syscall_64.c b/arch/x86/entry/syscall_64.c
> index be120eec1fc9..9e4a3d8957f3 100644
> --- a/arch/x86/entry/syscall_64.c
> +++ b/arch/x86/entry/syscall_64.c
> @@ -1,12 +1,22 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /* System call table for x86-64. */
>
> -#include <linux/linkage.h>
> -#include <linux/sys.h>
> -#include <linux/cache.h>
> -#include <linux/syscalls.h>
>  #include <asm/syscall.h>
>
> +struct pt_regs;
> +typedef long (*sys_call_ptr_t)(const struct pt_regs *);
> +extern const sys_call_ptr_t sys_call_table[];
> +#if defined(CONFIG_X86_32)
> +#define ia32_sys_call_table sys_call_table
> +#else
> +/*
> + * These may not exist, but still put the prototypes in so we
> + * can use IS_ENABLED().
> + */
> +extern const sys_call_ptr_t ia32_sys_call_table[];
> +extern const sys_call_ptr_t x32_sys_call_table[];
> +#endif
> +

arch/x86/include/asm/syscall.h (which you retained) already includes
the typedef for sys_call_ptr_t, and the declaration of sys_call_table,
and everything else.

Was there some additional refactoring that Al mentioned or intended
for you to do here?  Perhaps as part of a series so it's more obvious
to reviewers? You can include a Link: tag (see `git log` for examples)
in a commit message to link back to discussions on lore.kernel.org.
Doing so can help provide more context to reviewers as to //why// or
justification for a change.

Otherwise I'm not sure you need any of these additions (other than
maybe pt_regs).

>  #define __SYSCALL(nr, sym) extern long __x64_##sym(const struct pt_regs *);
>  #include <asm/syscalls_64.h>
>  #undef __SYSCALL
>
> ---
> base-commit: f5837722ffecbbedf1b1dbab072a063565f0dad1
> change-id: 20231228-syscall_64-30ba68440a85
>
> Best regards,
> --
> Tanzir Hasan <tanzirh@...gle.com>
>


-- 
Thanks,
~Nick Desaulniers