linux-kernel - Re: [PATCH v6 09/12] x86/sgx: Restructure top-level EPC reclaim function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.2g1jdlojwjvjmi@hhuan26-mobl.amr.corp.intel.com>
Date: Thu, 04 Jan 2024 15:01:59 -0600
From: "Haitao Huang" <haitao.huang@...ux.intel.com>
To: "Mehta, Sohil" <sohil.mehta@...el.com>, "jarkko@...nel.org"
 <jarkko@...nel.org>, "x86@...nel.org" <x86@...nel.org>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
 "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>, "hpa@...or.com"
 <hpa@...or.com>, "mingo@...hat.com" <mingo@...hat.com>, "tj@...nel.org"
 <tj@...nel.org>, "mkoutny@...e.com" <mkoutny@...e.com>, "tglx@...utronix.de"
 <tglx@...utronix.de>, "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "bp@...en8.de"
 <bp@...en8.de>, "Huang, Kai" <kai.huang@...el.com>, "Dave Hansen"
 <dave.hansen@...el.com>
Cc: "mikko.ylinen@...ux.intel.com" <mikko.ylinen@...ux.intel.com>,
 "seanjc@...gle.com" <seanjc@...gle.com>, "Zhang, Bo" <zhanb@...rosoft.com>,
 "kristen@...ux.intel.com" <kristen@...ux.intel.com>, "anakrish@...rosoft.com"
 <anakrish@...rosoft.com>, "sean.j.christopherson@...el.com"
 <sean.j.christopherson@...el.com>, "Li, Zhiquan1" <zhiquan1.li@...el.com>,
 "yangjie@...rosoft.com" <yangjie@...rosoft.com>
Subject: Re: [PATCH v6 09/12] x86/sgx: Restructure top-level EPC reclaim
 function

On Thu, 04 Jan 2024 13:27:07 -0600, Dave Hansen <dave.hansen@...el.com>  
wrote:

> On 1/4/24 11:11, Haitao Huang wrote:
>> If those are OK with users and also make it acceptable for merge
>> quickly, I'm happy to do that 🙂
>
> How about we put some actual numbers behind this?  How much complexity
> are we talking about here?  What's the diffstat for the utterly
> bare-bones implementation and what does it cost on top of that to do the
> per-cgroup reclaim?
>

For bare-bone:

  arch/x86/Kconfig                     |  13 ++++++++++++
  arch/x86/kernel/cpu/sgx/Makefile     |   1 +
  arch/x86/kernel/cpu/sgx/epc_cgroup.c | 104  
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/x86/kernel/cpu/sgx/epc_cgroup.h |  39  
+++++++++++++++++++++++++++++++++++
  arch/x86/kernel/cpu/sgx/main.c       |  41  
++++++++++++++++++++++++++++++++++++
  arch/x86/kernel/cpu/sgx/sgx.h        |   5 +++++
  include/linux/misc_cgroup.h          |  42  
+++++++++++++++++++++++++++++++++++++
  kernel/cgroup/misc.c                 |  52  
+++++++++++++++++++++++++++++++---------------
  8 files changed, 281 insertions(+), 16 deletions(-)

Additional for per-cgroup reclaim:

  arch/x86/kernel/cpu/sgx/encl.c       |  41 +++++++++--------
  arch/x86/kernel/cpu/sgx/encl.h       |   3 +-
  arch/x86/kernel/cpu/sgx/epc_cgroup.c | 224  
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
  arch/x86/kernel/cpu/sgx/epc_cgroup.h |  18 ++++++--
  arch/x86/kernel/cpu/sgx/main.c       | 226  
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------
  arch/x86/kernel/cpu/sgx/sgx.h        |  85  
+++++++++++++++++++++++++++++++++--
  6 files changed, 480 insertions(+), 117 deletions(-)


Thanks
Haitao