linux-kernel - Re: [PATCH 2/5] arm64: dts: add description for solidrun am642 som and evaluation board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c28ab577-35ad-45f6-8be4-08b441cdb50b@linaro.org>
Date: Thu, 4 Jan 2024 12:22:19 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Josua Mayer <josua@...id-run.com>, Nishanth Menon <nm@...com>,
 Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] arm64: dts: add description for solidrun am642 som
 and evaluation board

On 04/01/2024 12:01, Josua Mayer wrote:


>>> +
>>> +	leds {
>>> +		compatible = "gpio-leds";
>>> +		pinctrl-names = "default";
>>> +		pinctrl-0 = <&leds_pins_default>;
>>> +		status = "okay";
>> Where was it disabled?
> Nowhere. Better to omit status on new nodes added by new dts file?

Yes, you should not have any redundant status properties. okay is by
default.

>>> +
>>> +		/* D24 */
>>> +		led1: led-1 {
>>> +			label = "led1:green";
>> Use function
> This board has no default function defined by labels or enclosure.
> Not sure what to pick for "function" property. Can I omit it and set only color?
> 
> If so - should I drop label completely - or keep the "led1"  part?

Then keep label.



Best regards,
Krzysztof