linux-kernel - Re: [PATCH 2/5] arm64: dts: add description for solidrun am642 som and evaluation board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a7c032a-a1e7-4956-99dd-208dd4bdf8a4@solid-run.com>
Date: Thu, 4 Jan 2024 11:25:36 +0000
From: Josua Mayer <josua@...id-run.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Nishanth Menon
	<nm@...com>, Vignesh Raghavendra <vigneshr@...com>, Tero Kristo
	<kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] arm64: dts: add description for solidrun am642 som
 and evaluation board


Am 04.01.24 um 12:22 schrieb Krzysztof Kozlowski:
> On 04/01/2024 12:01, Josua Mayer wrote:
>
>
>>>> +
>>>> +	leds {
>>>> +		compatible = "gpio-leds";
>>>> +		pinctrl-names = "default";
>>>> +		pinctrl-0 = <&leds_pins_default>;
>>>> +		status = "okay";
>>> Where was it disabled?
>> Nowhere. Better to omit status on new nodes added by new dts file?
> Yes, you should not have any redundant status properties. okay is by
> default.
Okay, thanks.
>
>>>> +
>>>> +		/* D24 */
>>>> +		led1: led-1 {
>>>> +			label = "led1:green";
>>> Use function
>> This board has no default function defined by labels or enclosure.
>> Not sure what to pick for "function" property. Can I omit it and set only color?
>>
>> If so - should I drop label completely - or keep the "led1"  part?
> Then keep label.
Just to be clear, which is correct?:
a) label = "led1:green";
b) label = "led1"; color = <LED_COLOR_ID_GREEN>;
>
>
>
> Best regards,
> Krzysztof
>