linux-kernel - Re: [PATCH v1 1/4] perf vendor events intel: Alderlake/rocketlake metric fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8af821dc-d173-483d-8b69-b8e041538561@linux.intel.com>
Date: Thu, 4 Jan 2024 09:30:22 -0500
From: "Liang, Kan" <kan.liang@...ux.intel.com>
To: Ian Rogers <irogers@...gle.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
 Adrian Hunter <adrian.hunter@...el.com>, linux-perf-users@...r.kernel.org,
 linux-kernel@...r.kernel.org, Edward Baker <edward.baker@...el.com>
Subject: Re: [PATCH v1 1/4] perf vendor events intel: Alderlake/rocketlake
 metric fixes



On 2024-01-04 8:56 a.m., Ian Rogers wrote:
>> Testing tma_slow_pause
>> Metric 'tma_slow_pause' not printed in:
>> # Running 'internals/synthesize' benchmark:
>> Computing performance of single threaded perf event synthesis by
>> synthesizing events on the perf process itself:
>>   Average synthesis took: 49.987 usec (+- 0.049 usec)
>>   Average num. events: 47.000 (+- 0.000)
>>   Average time per event 1.064 usec
>>   Average data synthesis took: 53.490 usec (+- 0.033 usec)
>>   Average num. events: 245.000 (+- 0.000)
>>   Average time per event 0.218 usec
>>
>>  Performance counter stats for 'perf bench internals synthesize':
>>
>>      <not counted>      cpu_core/TOPDOWN.SLOTS/                                                 (0.00%)
>>      <not counted>      cpu_core/topdown-retiring/                                              (0.00%)
>>      <not counted>      cpu_core/topdown-mem-bound/                                             (0.00%)
>>      <not counted>      cpu_core/topdown-bad-spec/                                              (0.00%)
>>      <not counted>      cpu_core/topdown-fe-bound/                                              (0.00%)
>>      <not counted>      cpu_core/topdown-be-bound/                                              (0.00%)
>>      <not counted>      cpu_core/RESOURCE_STALLS.SCOREBOARD/                                        (0.00%)
>>      <not counted>      cpu_core/EXE_ACTIVITY.1_PORTS_UTIL/                                        (0.00%)
>>      <not counted>      cpu_core/EXE_ACTIVITY.BOUND_ON_LOADS/                                        (0.00%)
>>      <not counted>      cpu_core/CPU_CLK_UNHALTED.PAUSE/                                        (0.00%)
>>      <not counted>      cpu_core/CYCLE_ACTIVITY.STALLS_TOTAL/                                        (0.00%)
>>      <not counted>      cpu_core/CPU_CLK_UNHALTED.THREAD/                                        (0.00%)
>>      <not counted>      cpu_core/ARITH.DIV_ACTIVE/                                              (0.00%)
>>      <not counted>      cpu_core/EXE_ACTIVITY.2_PORTS_UTIL,umask=0xc/                                        (0.00%)
>>      <not counted>      cpu_core/EXE_ACTIVITY.3_PORTS_UTIL,umask=0x80/                                        (0.00%)
>>
>>        1.186254766 seconds time elapsed
>>
>>        0.427220000 seconds user
>>        0.752217000 seconds sys
>> Testing smi_cycles
>> Testing smi_num
>> Testing tsx_aborted_cycles
>> Testing tsx_cycles_per_elision
>> Testing tsx_cycles_per_transaction
>> Testing tsx_transactional_cycles
>> test child finished with -1
>> ---- end ----
>> perf all metrics test: FAILED!
>> root@...ber:~#
> Have a try disabling the NMI watchdog. Agreed that there is more to
> fix here but I think the PMU driver is in part to blame because
> manually breaking the weak group of events is a fix. 

I think we have a NO_GROUP_EVENTS_NMI metric constraint to mark a group
which require disabling of the NMI watchdog.
Maybe we should mark the group a NO_GROUP_EVENTS_NMI metric.

Thanks,
Kan

> Fwiw, if we
> switch to the buddy watchdog mechanism then we'll no longer need to
> disable the NMI watchdog:
> https://lore.kernel.org/lkml/20230421155255.1.I6bf789d21d0c3d75d382e7e51a804a7a51315f2c@changeid/