linux-kernel - Re: [PATCH] list: Add hlist_count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZZlhK6rF8gSy0toK@smile.fi.intel.com>
Date: Sat, 6 Jan 2024 16:18:19 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Marco Elver <elver@...gle.com>
Cc: Pierre Gondois <pierre.gondois@....com>, linux-kernel@...r.kernel.org,
	Kees Cook <keescook@...omium.org>,
	Lucas De Marchi <lucas.demarchi@...el.com>,
	Jani Nikula <jani.nikula@...el.com>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] list: Add hlist_count_nodes()

On Wed, Jan 03, 2024 at 02:46:00PM +0100, Marco Elver wrote:
> On Wed, 3 Jan 2024 at 13:04, Pierre Gondois <pierre.gondois@....com> wrote:
> > On 1/3/24 12:25, Marco Elver wrote:
> > > On Wed, 3 Jan 2024 at 10:02, Pierre Gondois <pierre.gondois@....com> wrote:
> > >>
> > >> Add a function to count nodes in a hlist. hlist_count_nodes()
> > >> is similar to list_count_nodes().
> > >>
> > >> Signed-off-by: Pierre Gondois <pierre.gondois@....com>
> > >
> > > Is this patch part of another patch series? As-is, this will be dead
> > > code, and there's no guarantee someone will just go and delete it in
> > > future. Although this function looks useful, we also should avoid
> > > adding new dead code.
> >
> > The function is indeed not used in the project right now. I needed
> > it for a private module. If it helps integrating the function and
> > not make it dead code, maybe I could add usages at the following
> > places:
> > - drivers/gpu/drm/drm_hashtab.c::print_binder_node_nilocked()
> > - drivers/md/bcache/sysfs.c::bch_cache_max_chain()
> 
> If this function allows to simplify these other places, by all means
> go ahead. That would look a lot better than having an unused function.

+1, produce a little series with those drivers being cleaned up.

-- 
With Best Regards,
Andy Shevchenko