[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b8f417a0-14b1-4d02-92d1-bf9469d38eb1@linaro.org>
Date: Sat, 6 Jan 2024 17:53:31 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Bhavin Sharma <bhavin.sharma@...iconsignals.io>, sre@...nel.org
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] power: supply: Add STC3117 fuel gauge unit driver
On 06/01/2024 14:35, Bhavin Sharma wrote:
> Adding support for stc3117 fuel gauge driver with
> minimal functionality to read voltage level currently
>
> Signed-off-by: Bhavin Sharma <bhavin.sharma@...iconsignals.io>
> ---
> drivers/power/supply/Kconfig | 7 ++
> drivers/power/supply/Makefile | 1 +
> drivers/power/supply/stc3117_fuel_gauge.c | 136 ++++++++++++++++++++++
> 3 files changed, 144 insertions(+)
> create mode 100644 drivers/power/supply/stc3117_fuel_gauge.c
>
I see now that you got review for your v1. You must implement it fully.
Second, don't send patchsets more often than one per day to allow people
to actually review your code. Especially if you do not test it (neither
v1 nor v2!).
Best regards,
Krzysztof
Powered by blists - more mailing lists