linux-kernel - Re: [PATCH v4 0/3] w1: add UART w1 bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1aeff309-6867-4296-8983-a60e8fd31614@linaro.org>
Date: Sat, 6 Jan 2024 17:56:34 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: cj.winklhofer@...il.com, Rob Herring <robh+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Jonathan Corbet <corbet@....net>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 0/3] w1: add UART w1 bus driver

On 06/01/2024 17:02, Christoph Winklhofer via B4 Relay wrote:
> Hello!
> 
> This patch contains a driver for a 1-Wire bus over UART. The driver
> utilizes the UART interface via the Serial Device Bus to create the
> 1-Wire timing patterns.
> 
> Changes in v4:
> - rework baud-rate configuration: also check max bit-time, support higher
>   baud-rates by adding a delay to complete 1-Wire cycle.
> - dt-binding w1-uart: specify baud-rates for 1-Wire operations
> - Link to v3: https://lore.kernel.org/r/20240105-w1-uart-v3-0-8687093b2e76@gmail.com
> 

You can slow down a bit. You sent v2 too late to be applied. Then you
sent v3 and next day v4.

While I like approach to release early, release often, it does not
necessarily apply to the bindings. Bindings should be complete, which
means they should describe the hardware as fully as possible.

About the driver, you can develop it incrementally, it is a good idea,
however since ~rc6 my w1 tree is closed. It will remain closed till next
rc1 is released (merge window finished). Nothing will get applied during
that time, so if you intend to add new features, better to send v5 after
the merge window (instead v4 now, v5 tomorrow, v6 next week and then v7
after rc1).

Best regards,
Krzysztof