[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d584255f-87ee-48a7-869d-e2a0b40a52b4@linaro.org>
Date: Tue, 9 Jan 2024 20:17:00 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Andrew Davis <afd@...com>, Frank Binns <frank.binns@...tec.com>,
Matt Coster <matt.coster@...tec.com>,
"H . Nikolaus Schaller" <hns@...delico.com>, Adam Ford <aford173@...il.com>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>, BenoƮt Cousson
<bcousson@...libre.com>, Tony Lindgren <tony@...mide.com>,
Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>, Paul Cercueil <paul@...pouillou.net>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-omap@...r.kernel.org,
linux-mips@...r.kernel.org
Subject: Re: [PATCH 01/11] dt-bindings: gpu: Rename img,powervr to
img,powervr-rogue
On 09/01/2024 20:04, Andrew Davis wrote:
> On 1/9/24 12:59 PM, Krzysztof Kozlowski wrote:
>> On 09/01/2024 18:19, Andrew Davis wrote:
>>> This binding will be used for GPUs starting from Series6 (Rogue)
>>> and later. A different binding document will describe Series5.
>>> With that the name "img,powervr" is too generic, rename to
>>> "img,powervr-rogue" to avoid confusion.
>>>
>>> Suggested-by: Maxime Ripard <mripard@...nel.org>
>>> Signed-off-by: Andrew Davis <afd@...com>
>>> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
>>> Reviewed-by: Frank Binns <frank.binns@...tec.com>
>>> ---
>>
>> Why do you send new version while we still talk about previous?
>>
>> Please implement feedback from v1 (and this is v2, so next is v3) or
>> keep discussing.
>>
>
> I agreed with everything you said in the last round (RFC v2) and
> made all requested changes. Did I miss something in this version?
The recommendation is that naming of the file matches generic compatible
and your file has only one generic compatible. Therefore I don't
understand why you claimed there are multiple compatibles.
Best regards,
Krzysztof
Powered by blists - more mailing lists